Skip to content

Added 'dependencies', 'license' and 'provides_includes' fields in lib search #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2020
Merged

Added 'dependencies', 'license' and 'provides_includes' fields in lib search #599

merged 3 commits into from
Feb 28, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 28, 2020 •
edited
Loading

  • Added dependencies, license and provides_includes fields in search library responses, becuase they were missing.
  • In text output do not print the above fields when they are empty
$ ./arduino-cli lib search Blynk_Esp8266AT_WM 
Name: "Blynk_Esp8266AT_WM"
  Author: Khoi Hoang
  Maintainer: Khoi Hoang <[email protected]>
  Sentence: Simple WiFiManager for Blynk and Mega/Teensy/SAMD boards running ESP8266 AT shields, configuration data saved in EEPROM
  Paragraph: Library for configuring/auto(re)connecting Mega and Teensy running ESP8266 AT shields to WiFi and Blynk at runtime.
  Website: https://github.com/khoih-prog/Blynk_Esp8266AT_WM
  License: MIT
  Category: Communication
  Architecture: *
  Types: Contributed
  Versions: [1.0.0, 1.0.1, 1.0.2]
  Dependencies: Blynk, ESP8266_AT_WebServer

$ ./arduino-cli lib search ADG2128 
Name: "ADG2128"
  Author: J. Ian Lindsay <[email protected]>
  Maintainer: J. Ian Lindsay <[email protected]>
  Sentence: A library for the ADG2128 analog cross-point switch.
  Paragraph: 
  Website: https://github.com/jspark311/Arduino-ADG2128
  Category: Sensors
  Architecture: *
  Types: Contributed
  Versions: [1.0.0]
  Dependencies: CppPotpourri

@cmaglie cmaglie requested review from masci and rsora February 28, 2020 14:41
@cmaglie cmaglie self-assigned this Feb 28, 2020
@cmaglie
Added 'dependencies' field in lib search
7f1d27a
@cmaglie
Do not output empty field in 'lib search'
e4590f4 
Fields 'license', 'provided includes' and 'dependencies' are printed
only if populated.
@cmaglie cmaglie changed the title Added 'license' and 'provides_includes' fields in lib search Added 'dependencies', 'license' and 'provides_includes' fields in lib search Feb 28, 2020
rsora
rsora approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmaglie cmaglie merged commit 4b874a0 into arduino:master Feb 28, 2020
@cmaglie cmaglie deleted the add_missing_fields_lib_search branch February 28, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

@masci masci Awaiting requested review from masci

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora